Aaaaaaron commented on a change in pull request #2211:
URL: https://github.com/apache/calcite/pull/2211#discussion_r526552481
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {
.check();
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-4317";>[CALCITE-4317]
+ * RelFieldTrimmer after trimming all the fields in an aggregate
+ * should not return a zero field Aggregate</a>. */
+ @Test void testProjectJoinTransposeRuleOnAggWithNoFieldsWithTrimmer() {
Review comment:
@a-rafay "then it shouldn't matter what test case we used if the nature
of test case is the same." yes, this is what I mean, @rubenada can you help
review and merge this PR, I've been met this times, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
