ILuffZhe commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r774257965
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
"aggregations:{'v1.max.field': 'val1'",
"'v2.min.field': 'val2'}"))
.returnsUnordered("v1=7; v2=5");
+ }
+
+ @Test void testNullsSort() {
Review comment:
I've thought about adding NULLS ORDER tests in ElasticSearchAdapterTest,
which is more reasonable.
However, many tests are disabled after CALCITE-4101(see
https://github.com/apache/calcite/commit/e7aca6914c65bd812a9b177c438f687b77e090af),
as a result of CI failure.
I think it's better to recover those test cases. What do you suggest?
@NobiGo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
