zabetak commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r779581295
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
"aggregations:{'v1.max.field': 'val1'",
"'v2.min.field': 'val2'}"))
.returnsUnordered("v1=7; v2=5");
+ }
+
+ @Test void testNullsSort() {
Review comment:
@ILuffZhe I don't have a strong preference.
There are already "feature" specific classes such as "ProjectionTest",
"MatchTest", etc., so I wouldn't be surprised if there is a new class
emphasizing on sorting and nulls.
On the other hand you could definitely add another dataset in
`ElasticSearchAdapterTest` and add test cases in that class. You may draw some
inspiration from `JdbcAdapterTest` where each test uses a specific `model`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
