NobiGo commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r781119518
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRel.java
##########
@@ -54,6 +55,12 @@
*/
final List<Map.Entry<String, RelFieldCollation.Direction>> sort = new
ArrayList<>();
+ /**
+ * Sorting missing values.
+ * @see <a
href="https://www.elastic.co/guide/en/elasticsearch/reference/current/sort-search-results.html#_missing_values";>Missing
Values</a>
+ */
+ final Map<String, RelFieldCollation.NullDirection> nullsSort = new
HashMap<>();
Review comment:
I suspect this use Map have some hidden problems when handle have
duplicate columns. I suggest we use `List<Map.Entry<String,
RelFieldCollation.Direction>>` to handle this.
##########
File path: elasticsearch/src/test/resources/zips-mini-nullable.json
##########
@@ -0,0 +1,6 @@
+{"age" : 21, "name" : "testName1", "score" : 91, "weight" : 65.0}
Review comment:
This different between zips-mini-nullable and zips-min file should be
the NULL value, Others please stay same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
