NobiGo commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r779972017
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
"aggregations:{'v1.max.field': 'val1'",
"'v2.min.field': 'val2'}"))
.returnsUnordered("v1=7; v2=5");
+ }
+
+ @Test void testNullsSort() {
Review comment:
I think we should add another like zips-mini-nullable.json file include
NULL value in doc, then after when we need add another test for NULL value
inlucde aggregate... can base on this doc. About Where the unit test should be,
I don't have a strong preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
