ILuffZhe commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r785288597
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchMapping.java
##########
@@ -102,19 +105,28 @@ String index() {
private static final JsonNodeFactory FACTORY = JsonNodeFactory.instance;
// pre-cache missing values
- private static final Set<JsonNode> MISSING_VALUES =
+ private static final Set<JsonNode> MIN_MISSING_VALUES =
Stream.of("string", // for ES2
"text", "keyword",
"date", "long", "integer", "double", "float")
- .map(Datatype::missingValueForType)
+ .map(Datatype::minMissingValueForType)
+ .collect(Collectors.toSet());
+
+ private static final Set<JsonNode> MAX_MISSING_VALUES =
Review comment:
Hi @asereda-gs . I've updated the PR according to the discussions. For
text/keyword type, I use "~"(for max) to replace missing value, which has
greater ASCII value than "z".
If you have any other opinions, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
