ILuffZhe commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r785276539
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchMapping.java
##########
@@ -102,19 +105,28 @@ String index() {
private static final JsonNodeFactory FACTORY = JsonNodeFactory.instance;
// pre-cache missing values
- private static final Set<JsonNode> MISSING_VALUES =
+ private static final Set<JsonNode> MIN_MISSING_VALUES =
Stream.of("string", // for ES2
"text", "keyword",
"date", "long", "integer", "double", "float")
- .map(Datatype::missingValueForType)
+ .map(Datatype::minMissingValueForType)
+ .collect(Collectors.toSet());
+
+ private static final Set<JsonNode> MAX_MISSING_VALUES =
Review comment:
You are right. I'll add those two value for text/keyword type. By the
way, it seems hard to define a specific value for MAX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
