ILuffZhe commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r781805071
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
"aggregations:{'v1.max.field': 'val1'",
"'v2.min.field': 'val2'}"))
.returnsUnordered("v1=7; v2=5");
+ }
+
+ @Test void testNullsSort() {
Review comment:
For this case, one small dataset is enough. And personally speaking,
adding a new test class is much more convenient. So, your advice is reasonable.
As for why I add a new dataset in ElasticSearchAdapterTest, I think creating
an index seems a little better than creating a test class when the existing
data is not satisfied for fixing bugs, which require not many tests.
We might need a third opinion here. What do you think? @zabetak @NobiGo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
