ILuffZhe commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r785275522
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchMapping.java
##########
@@ -102,19 +105,28 @@ String index() {
private static final JsonNodeFactory FACTORY = JsonNodeFactory.instance;
// pre-cache missing values
- private static final Set<JsonNode> MISSING_VALUES =
+ private static final Set<JsonNode> MIN_MISSING_VALUES =
Stream.of("string", // for ES2
"text", "keyword",
"date", "long", "integer", "double", "float")
- .map(Datatype::missingValueForType)
+ .map(Datatype::minMissingValueForType)
+ .collect(Collectors.toSet());
+
+ private static final Set<JsonNode> MAX_MISSING_VALUES =
Review comment:
Currently, "\_\_MISSING\_\_" is used for text/keyword type in agg terms.
Just like [CALCITE-4896](https://issues.apache.org/jira/browse/CALCITE-4896)
mentioned, some certain context cannot be dealt well, and I still don't find a
better way. Do you have any good ideas on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
