jnturton opened a new pull request #2698: URL: https://github.com/apache/calcite/pull/2698
## What is the purpose of the change The change attempts to address a resource leak bug believed to result from no call to RestClient#close() being made. [Docs describing the need for this call are online here](https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-low-usage-initialization.html). The call to RestClient#close() is added to a new `finalize()` method in ElasticsearchTransport because no other suitable lifecycle method was in evidence. Any suggestion of better place to make this call is welcome. ## Verifying this change File descriptor resource leaks such as we have observed in the context connecting Apache Drill to ElasticSearch (which goes via Calcite) are not easy to unit test. I'm open to ideas here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
