NobiGo commented on a change in pull request #2698:
URL: https://github.com/apache/calcite/pull/2698#discussion_r790245642
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchTransport.java
##########
@@ -224,6 +224,16 @@ void closeScroll(Iterable<String> scrollIds) {
return rawHttp(ElasticsearchJson.Result.class).apply(post);
};
}
+
+
+
+ @Override
+ protected void finalize() throws Throwable {
Review comment:
[JEP 421: Deprecate Finalization for
Removal](https://openjdk.java.net/jeps/421?continueFlag=abef66f10493295d8376160baf41892b)
This address have some way to replace the finalize method and Why we should
avoid using it. I hope it can help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
