zabetak commented on a change in pull request #2698:
URL: https://github.com/apache/calcite/pull/2698#discussion_r790148694
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchTransport.java
##########
@@ -224,6 +224,16 @@ void closeScroll(Iterable<String> scrollIds) {
return rawHttp(ElasticsearchJson.Result.class).apply(post);
};
}
+
+
+
+ @Override
+ protected void finalize() throws Throwable {
Review comment:
Finalizers are a java concept that is strongly discouraged for quite
some time now. Moreover, they are going to [disappear
soon](https://www.youtube.com/watch?v=eDgBnjOid-g) so let's find another way to
handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
