korlov42 commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r826963024
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalProject.java
##########
@@ -58,29 +61,34 @@
* @param input Input relational expression
* @param projects List of expressions for the input columns
* @param rowType Output row type
+ * @param variablesSet Correlation variables set by this relational
expression
+ * to be used by nested expressions
*/
public LogicalProject(
RelOptCluster cluster,
RelTraitSet traitSet,
List<RelHint> hints,
RelNode input,
List<? extends RexNode> projects,
- RelDataType rowType) {
- super(cluster, traitSet, hints, input, projects, rowType);
+ RelDataType rowType,
+ Set<CorrelationId> variablesSet) {
+ super(cluster, traitSet, hints, input, projects, rowType, variablesSet);
assert traitSet.containsIfApplicable(Convention.NONE);
}
Review comment:
yes, it's better to preserve compatibility. So, I've returned and
deprecated the old constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
