korlov42 commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r827070155
##########
File path:
cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraRules.java
##########
@@ -258,7 +258,8 @@ private static boolean isEqualityOnKey(RexNode node,
List<String> fieldNames,
public static class CassandraProjectRule extends CassandraConverterRule {
/** Default configuration. */
private static final Config DEFAULT_CONFIG = Config.INSTANCE
- .withConversion(LogicalProject.class, Convention.NONE,
+ .withConversion(LogicalProject.class, p -> p.getCorrelVariable() ==
null
+ || p.getVariablesSet().isEmpty(), Convention.NONE,
Review comment:
This looks like attempt to check if collection is null or empty, but
something went wrong... Fixed this to verify both `p.getCorrelVariable()` and
`p.getVariablesSet()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
