korlov42 commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r828187009
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
##########
@@ -187,7 +187,7 @@ protected FilterProjectTransposeRule(
RelNode newProject =
config.isCopyProject()
? project.copy(project.getTraitSet(), newFilterRel,
Review comment:
Do we really need to investigate _all the rules_ within this PR? This
requires a lot of effort, whereas the benefit is small. I mean, for years
downstream projects were dealing with correlated subqueries in the project, and
no one cares about empty set returned from `getVariablesSet()`. Does it make
sence to fix those rules step by step whenever the problem arises?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
