korlov42 commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r827095152
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ProjectWindowTransposeRule.java
##########
@@ -99,7 +100,7 @@ public ProjectWindowTransposeRule(RelBuilderFactory
relBuilderFactory) {
final LogicalProject projectBelowWindow =
new LogicalProject(cluster, window.getTraitSet(), ImmutableList.of(),
- window.getInput(), exps, builder.build());
+ window.getInput(), exps, builder.build(), ImmutableSet.of());
Review comment:
If my understanding correct, we only transpose an identity project,
otherwise the identity project will be derived and passed below the window and
the topmost project will be adjusted. In that case it looks safe.
> Also it seems that here we are going to lose the variables set in the
original projection
It's a bug, thank you for noticing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
