zabetak commented on code in PR #3185:
URL: https://github.com/apache/calcite/pull/3185#discussion_r1183000299
##########
core/src/main/java/org/apache/calcite/plan/RelOptPlanner.java:
##########
@@ -350,4 +350,49 @@ public CannotPlanException(String message) {
super(message);
}
}
+
+ /**
+ * Converts a relation expression to a given set of traits, if it does not
Review Comment:
I am wondering if it is a good idea to add yet another `convert` method or
if it would be better to put this logic into the existing `changeTraits` method
inside the planner and change rules to call `changeTraits` directly.
The `VolcanoPlanner#changeTraits` already has some assertions that the
traits are different so it may make sense to relax it and bail out instead.
The `HepPlanner#changeTraits` does not care much about traits so we should
be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
