rubenada commented on code in PR #3185:
URL: https://github.com/apache/calcite/pull/3185#discussion_r1196143422
##########
core/src/main/java/org/apache/calcite/plan/RelOptPlanner.java:
##########
@@ -350,4 +350,49 @@ public CannotPlanException(String message) {
super(message);
}
}
+
+ /**
+ * Converts a relation expression to a given set of traits, if it does not
Review Comment:
Thanks for the feedback @zabetak !
I'm looking again into this, and currently there are a lot of ConverterRules
that still call `RelOptRule#convert`, so in order to deprecate it, we should
refactor those too (not covered by the PR as it is right now).
In any case, I think we might want to refactor them and avoid calling
`RelOptRule#convert` in their case too, because theoretically the same problem
could happen on them (maybe it is a bit more far-fetched to see it in a real
production env, but I have been able to force it in a UT). I don't have much
time atm to re-work this, I'll try to circle back to it in the coming days...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
