rubenada commented on code in PR #3185:
URL: https://github.com/apache/calcite/pull/3185#discussion_r1184897174
##########
core/src/main/java/org/apache/calcite/plan/RelOptPlanner.java:
##########
@@ -350,4 +350,49 @@ public CannotPlanException(String message) {
super(message);
}
}
+
+ /**
+ * Converts a relation expression to a given set of traits, if it does not
Review Comment:
@zabetak I have applied your idea on the second commit:
- Move convert logic out of `RelOptPlanner` back to `RelOptRule`
- Inside rule `onMatch`, call directly planner `changeTraits` instead of
convert
- Relax assertions inside `VolcanoPlanner#changeTraits`
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
