zabetak commented on code in PR #3185:
URL: https://github.com/apache/calcite/pull/3185#discussion_r1183786593
##########
core/src/main/java/org/apache/calcite/plan/RelOptPlanner.java:
##########
@@ -350,4 +350,49 @@ public CannotPlanException(String message) {
super(message);
}
}
+
+ /**
+ * Converts a relation expression to a given set of traits, if it does not
Review Comment:
I think the risk is small given that we have the assertions about traits in
the Volcano planner. I feel that having less APIs for extension and maintenance
is positive for the future of the project but maybe other have a different
opinion; feel free to open the discussion to the dev list if you like.
If we decide to go for new methods then I guess I like more your suggestion
about adding a new `RelOptRule#convert` with an additional planner parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
