snuyanzin commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1215568135
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3870,7 +3870,7 @@ private static AtomicLong getAtomicLong(String key) {
}
/** Support the ARRAY_COMPACT function. */
- public static List compact(List list) {
+ public static List arrayCompact(List list) {
Review Comment:
I didn't get it
I see a review comment here
https://github.com/apache/calcite/pull/3233#discussion_r1210553037
to use `compact` name and from my point of view this is fine since with such
name there is no confusion about `List` and `array`
Where in review `arrayCompact` has appeared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
