liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1215612398
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3870,7 +3870,7 @@ private static AtomicLong getAtomicLong(String key) {
}
/** Support the ARRAY_COMPACT function. */
- public static List compact(List list) {
+ public static List arrayCompact(List list) {
Review Comment:
@snuyanzin i know you meaning. List is just array type's runtime
implementation. from my side, the name is ok. if you think it is not good, i
can change all of them to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
