snuyanzin commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1215600080
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3870,7 +3870,7 @@ private static AtomicLong getAtomicLong(String key) {
}
/** Support the ARRAY_COMPACT function. */
- public static List compact(List list) {
+ public static List arrayCompact(List list) {
Review Comment:
my concern is not about search, moreover i don't think search is an issue
since you have a comment with sql version
my concern is about name confusion which I raised in this thread
> ok then the naming became more confusing: `arrayCompact` says about
`array` however returns a `List`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
