liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1215588470
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3870,7 +3870,7 @@ private static AtomicLong getAtomicLong(String key) {
}
/** Support the ARRAY_COMPACT function. */
- public static List compact(List list) {
+ public static List arrayCompact(List list) {
Review Comment:
@snuyanzin
"this could also be named compact so it's easier to find, removeNulls is
also ok", this is in the comments you refer.
originally i use removeNulls then changed to compact, and i changed to
arrayCompact just because the spark function name is arrayCompact, which others
do it too. for search easy.
https://github.com/apache/calcite/pull/3212#discussion_r1213835525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
