mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819490524
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlUserDefinedFunction.java:
##########
@@ -61,9 +64,9 @@ public SqlUserDefinedFunction(SqlIdentifier opName, SqlKind
kind,
SqlReturnTypeInference returnTypeInference,
SqlOperandTypeInference operandTypeInference,
@Nullable SqlOperandMetadata operandMetadata,
- Function function) {
+ Function function, SqlSyntax syntax) {
Review Comment:
Since Calcite is an open-source library you cannot assume that the only code
that calls these functions is in the Calcite tree. There are lots of third
party projects using Calcite, and any of them may be calling any of the public
functions. You cannot break compatibility unless you change the major version
of the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
