mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819496088


##########
core/src/test/java/org/apache/calcite/test/UdfTest.java:
##########
@@ -423,7 +447,8 @@ private CalciteAssert.AssertThat withUdf() {
 
   @Test void testUdfOverloadedNullable() {
     final CalciteAssert.AssertThat with = withUdf();
-    with.query("values (\"adhoc\".count_args(),\n"
+    with.with(SqlConformanceEnum.MYSQL_5)

Review Comment:
   perhaps a comment explaining that MYSQL_5 allows nilladic functions without 
parentheses will help people understand the point. That is not obvious.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to