mihaibudiu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819499357
##########
testkit/src/main/java/org/apache/calcite/util/Smalls.java:
##########
@@ -683,6 +683,13 @@ public static int eval(int x) throws
IllegalArgumentException, IOException {
}
}
+ /** User-defined function with niladic parentheses. */
+ public static class MyNiladicParenthesesFunction {
+ public String eval() {
Review Comment:
The point I am making is that this is a test for a function with no
arguments, and there are two kinds of such functions: non-deterministic, and
constant. This is actually a constant function, and it is used for testing the
syntax. That's what the comment should say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
