strongduanmu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1819912373
##########
plus/src/main/java/org/apache/calcite/chinook/CalciteConnectionProvider.java:
##########
@@ -44,6 +44,7 @@ public Properties provideConnectionInfo() throws IOException {
Properties info = new Properties();
info.setProperty("lex", "MYSQL");
info.setProperty("model", "inline:" + provideSchema());
+ info.setProperty("conformance", "MYSQL_5");
Review Comment:
Considering the lex used by the connection provider is MySQL, I think it
should use MYSQL_5 conformance here, which makes the config consistent. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
