xuzifu666 commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068186194
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -214,6 +214,10 @@ public final class CalciteSystemProperty<T> {
return ".";
});
+
Review Comment:
Maybe we cannot put them in JdbcAdapterTest because need these static String
in CalciteAssert (in Calcite testkit and JdbcAdapterTest is in core moudle ),
how about put them in CalciteAssert with private static final ? @asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
