asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068325183
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1355,6 +1355,27 @@ private LockWrapper exclusiveCleanDb(Connection c)
throws SQLException {
.runs();
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6995";>[CALCITE-6995]
+ * StarRocks/Doris should support full join</a>.*/
+ @Test void testFullJoinSupportedDialect() {
+ CalciteAssert.model(JdbcTest.SCOTT_MODEL)
+ .enable(CalciteAssert.DB != CalciteAssert.DatabaseInstance.H2
Review Comment:
Q: I see no other tests where we enable when the DB is not set to a given
set of values (inequality), we always enable on specific values (equality). In
this case, do we want to enable it specifically for Doris/StarRocks or for all
DBs except the two you have excluded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
