xiedeyantu commented on code in PR #4465:
URL: https://github.com/apache/calcite/pull/4465#discussion_r2209014567


##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -645,6 +645,11 @@ private <C extends Comparable<C>> RexNode 
simplifyComparison(RexCall e,
       }
     }
 
+    RexNode node = simplifyComparisonWithNull(e, unknownAs);

Review Comment:
   My idea is to enter the logic
   ```
         if (againstNull) {
           return unknownAs == FALSE
               ? rexBuilder.makeLiteral(false)
               : rexBuilder.makeNullLiteral(e.getType());
         }
   ```
   and then consider it a successful simplification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to