xiedeyantu commented on code in PR #4465:
URL: https://github.com/apache/calcite/pull/4465#discussion_r2209028137
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -645,6 +645,11 @@ private <C extends Comparable<C>> RexNode
simplifyComparison(RexCall e,
}
}
+ RexNode node = simplifyComparisonWithNull(e, unknownAs);
Review Comment:
I understand what you mean. `simplifyComparisonWithNull` is used in two
places and needs to take into account two logics. I didn't think about it
enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
