julianhyde commented on code in PR #4487:
URL: https://github.com/apache/calcite/pull/4487#discussion_r2249462365


##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -987,6 +987,25 @@ private void checkLarge(int n) {
         .fails("(?s)Encountered \"-\" at .*")
         .withDialect(BIG_QUERY)
         .fails("(?s)Encountered \"-\" at .*");
+
+    final SqlConformance nonBigQueryConformance = new SqlAbstractConformance() 
{
+      @Override public boolean allowHyphenInUnquotedTableName() {
+        return true;
+      }
+    };
+
+    sql("select * from foo-bar.baz cross join (select alpha-omega from t) as 
t")
+        .withDialect(MYSQL)

Review Comment:
   This test and the one following it look identical. Yet one is supposed to 
succeed and the other to fail. How does that work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to