julianhyde commented on code in PR #4487:
URL: https://github.com/apache/calcite/pull/4487#discussion_r2250098172
##########
core/src/main/java/org/apache/calcite/sql/parser/SqlAbstractParserImpl.java:
##########
@@ -619,9 +619,11 @@ public static LexicalState forConfig(SqlParser.Config
config) {
return BQID;
case BACK_TICK:
if (config.conformance().allowHyphenInUnquotedTableName()
- && config.charLiteralStyles().equals(
+ && (config.charLiteralStyles().equals(
EnumSet.of(CharLiteralStyle.BQ_SINGLE,
- CharLiteralStyle.BQ_DOUBLE))) {
+ CharLiteralStyle.BQ_DOUBLE))
+ || config.charLiteralStyles().equals(
+ EnumSet.of(CharLiteralStyle.STANDARD)))) {
Review Comment:
Well, suppose someone has asked for Oracle-style quoted identifiers, `"my
table"`. If they also make `allowHyphenInUnquotedTableName` return true then
they aren't going to get the parser behavior that they asked for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
