snuyanzin commented on code in PR #4487:
URL: https://github.com/apache/calcite/pull/4487#discussion_r2254444740
##########
core/src/main/java/org/apache/calcite/sql/parser/SqlAbstractParserImpl.java:
##########
@@ -619,9 +619,11 @@ public static LexicalState forConfig(SqlParser.Config
config) {
return BQID;
case BACK_TICK:
if (config.conformance().allowHyphenInUnquotedTableName()
- && config.charLiteralStyles().equals(
+ && (config.charLiteralStyles().equals(
EnumSet.of(CharLiteralStyle.BQ_SINGLE,
- CharLiteralStyle.BQ_DOUBLE))) {
+ CharLiteralStyle.BQ_DOUBLE))
+ || config.charLiteralStyles().equals(
+ EnumSet.of(CharLiteralStyle.STANDARD)))) {
Review Comment:
yes, same happens without this PR changes, and makes me thinking that
javadoc doesn't reflect current behavior...
Initially (also put in jira description) I was thinking to make it working
for backticks quoting only.
Do you think it would make sense to make it working for all (asking since so
far I don't know well known DB vendors supporting this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
