snuyanzin commented on code in PR #4487:
URL: https://github.com/apache/calcite/pull/4487#discussion_r2249635620
##########
core/src/main/java/org/apache/calcite/sql/parser/SqlAbstractParserImpl.java:
##########
@@ -619,9 +619,11 @@ public static LexicalState forConfig(SqlParser.Config
config) {
return BQID;
case BACK_TICK:
if (config.conformance().allowHyphenInUnquotedTableName()
- && config.charLiteralStyles().equals(
+ && (config.charLiteralStyles().equals(
EnumSet.of(CharLiteralStyle.BQ_SINGLE,
- CharLiteralStyle.BQ_DOUBLE))) {
+ CharLiteralStyle.BQ_DOUBLE))
+ || config.charLiteralStyles().equals(
+ EnumSet.of(CharLiteralStyle.STANDARD)))) {
Review Comment:
then it is not clear what is the purpose of `allowHyphenInUnquotedTableName`
returning `true` then?
Isn't this what is meant in javadoc
https://github.com/apache/calcite/blob/2fafa5254e40ddcffbf1fcd9ae56c50954763dac/core/src/main/java/org/apache/calcite/sql/validate/SqlConformance.java#L247-L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
