mihaibudiu commented on PR #4465: URL: https://github.com/apache/calcite/pull/4465#issuecomment-3393495186
Sorry, I pushed to the wrong branch, should be fixed now. Mihai ________________________________ From: Ruben Quesada Lopez ***@***.***> Sent: Saturday, October 11, 2025 2:35 AM To: apache/calcite ***@***.***> Cc: Mihai Budiu ***@***.***>; Mention ***@***.***> Subject: Re: [apache/calcite] [CALCITE-7070] FILTER_REDUCE_EXPRESSIONS crashes on expression BETWEEN ( NULL) AND X (PR #4465) @rubenada commented on this pull request. ________________________________ In core/src/main/java/org/apache/calcite/rex/RexSimplify.java<https://github.com/apache/calcite/pull/4465#discussion_r2422686754>: > @@ -767,6 +772,49 @@ private <C extends Comparable<C>> RexNode simplifyComparison(RexCall e, return simplifyUsingPredicates(e2, clazz); } + + /** + * If this RexNode is a comparison against NULL, return FALSE, otherwise return it unchanged. + * This is a static simplified version of the function below. + */ + public static RexNode simplifyComparisonWithNull(RexNode e, RexBuilder rexBuilder) { Have you pushed it @mihaibudiu<https://github.com/mihaibudiu> ? I still see the duplicated code — Reply to this email directly, view it on GitHub<https://github.com/apache/calcite/pull/4465#discussion_r2422686754>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AET7TMQGNNJKS4NLEUGNRS33XDFO5AVCNFSM6AAAAACBQH7A5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMRWHEZDOMRRG4>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
