xuzifu666 commented on code in PR #4620:
URL: https://github.com/apache/calcite/pull/4620#discussion_r2517665833


##########
core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml:
##########
@@ -373,7 +371,6 @@ TableScan:[[PROPERTIES inheritPath:[] options:{K1=v1, 
K2=v2}], [PROPERTIES inher
     <Resource name="hints">
       <![CDATA[
 Project:[[FAST_SNAPSHOT inheritPath:[] options:[PRODUCTS_TEMPORAL]]]
-Snapshot:[[FAST_SNAPSHOT inheritPath:[0, 1] options:[PRODUCTS_TEMPORAL]]]

Review Comment:
   OK, I had changed it.
   Regarding whether the discussion can be independent of this PR, we can open 
a new jira to follow up. @dssysolyatin 



##########
core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml:
##########
@@ -373,7 +371,6 @@ TableScan:[[PROPERTIES inheritPath:[] options:{K1=v1, 
K2=v2}], [PROPERTIES inher
     <Resource name="hints">
       <![CDATA[
 Project:[[FAST_SNAPSHOT inheritPath:[] options:[PRODUCTS_TEMPORAL]]]
-Snapshot:[[FAST_SNAPSHOT inheritPath:[0, 1] options:[PRODUCTS_TEMPORAL]]]

Review Comment:
   OK, I had changed it.
   Regarding whether the discussion can be independent of this PR, we can open 
a new jira to follow up. what you think about it? @dssysolyatin 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to