dssysolyatin commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3529529480
@xuzifu666 I approved your PR, but it doesn’t really make sense to merge it as it is. The reason is that `AbstractRelNode` already has a default `accept` implementation that calls `RelShuttle.visit(RelNode other)` and your change does nothing. If you decide to add visitor method for `LogicalSnaphot`, be also aware of behaviour, that if user class: `X which extends LogicalSnapshot` and class `Y which extends Snapshot`. `X` will call `RelShuttle.visit(LogicalSnapshot)` and `Y` will call `RelShuttle.visit(RelNode other)`. It also should be documented that user aware of it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
