dssysolyatin commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3530908941
> Okay, it seems that everyone is basically in agreement I think I clearly explained my point of view during the PR review and in [CALCITE-7288]. As long as `RelShuttle.visit(RelNode other)` exists, we will keep forgetting to add new visit methods to `RelShuttle` for new RelNode types. If we add these methods later, it becomes a breaking change, and it’s easy to forget to document it. And user can forgot to read breaking changing if it is not compile error. About breaking changes, I already sent you a link with example: > See the example in Stamatis’s commit https://github.com/apache/calcite/commit/1ab5c7f8cc54a6df87dafe5371530443fa810e19#diff-c0eccc3130d0bc82b14113843abec157190ebb2551380fa754dbcdd56f61ea51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
