mihaibudiu commented on PR #4620: URL: https://github.com/apache/calcite/pull/4620#issuecomment-3522706920
The point of having visitors is exactly so you don't have to dispatch manually based on types (LogicalSnapshot), but have the compiler do the dispatch for you. This deserves a discussion in JIRA. There are many ways to design the visitors, and I haven't seen a spec for Calcite's visitors. For example, it's not clear whether the visitor method for LogicalSnapshot is supposed to call the visitor method for superclasses. But in general, if you have a new class that extends the visited objects (LogicalSnapshot extending RelNode), all visitors must potentially be extended to cope with the new class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
