mihaibudiu commented on code in PR #4761:
URL: https://github.com/apache/calcite/pull/4761#discussion_r2776165164
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -138,6 +138,14 @@ public final class CalciteSystemProperty<T> {
public static final CalciteSystemProperty<Boolean> TOPDOWN_OPT =
booleanProperty("calcite.planner.topdown.opt", false);
+
+ /** Whether to disable generate type digest string.
+ *
+ * <p> Disable generate type digest string for every type can
Review Comment:
Please be more explicit here: this is about the RelDataType.digest field.
"Type" can mean many things.
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java:
##########
@@ -60,7 +61,8 @@ public abstract class RelDataTypeImpl
//~ Instance fields --------------------------------------------------------
protected final @Nullable List<RelDataTypeField> fieldList;
- protected @Nullable String digest;
+ protected @Deprecated @Nullable String digest;
Review Comment:
Please add also a `@deprecated` JavaDoc comment explaining what users are
supposed to do instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
