zhuwenzhuang commented on code in PR #4761: URL: https://github.com/apache/calcite/pull/4761#discussion_r2806898385
########## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java: ########## @@ -60,7 +61,8 @@ public abstract class RelDataTypeImpl //~ Instance fields -------------------------------------------------------- protected final @Nullable List<RelDataTypeField> fieldList; - protected @Nullable String digest; + protected @Deprecated @Nullable String digest; Review Comment: 1.Yes. It has better performace and ondemand construction behavior. 2.Not a blocking point, if user set the String digest not null, all hashCode/equals/getXXXString logic will fallback to behaviors based on String digest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
