zhuwenzhuang commented on code in PR #4761: URL: https://github.com/apache/calcite/pull/4761#discussion_r2807120679
########## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java: ########## @@ -60,7 +61,8 @@ public abstract class RelDataTypeImpl //~ Instance fields -------------------------------------------------------- protected final @Nullable List<RelDataTypeField> fieldList; - protected @Nullable String digest; + protected @Deprecated @Nullable String digest; Review Comment: OK, @depredate mark may cause user's compiler thorw an error. And I think use RelDataTypeDigest to handle digest is better than String digest. I don't know should we add the @depredate mark to indicate this suggestion. For the java doc. "Use RelDataTypeDigest.getDigest().getDigestString() instead of digest" is one usage of digest. If users managed the String digest by not standard way(maybe UDT) ```java digest = "MyType"; ``` , they need implement this in ```java void generateTypeString(StringBuilder sb,boolean withDetail); ``` I'm not sure whether we need to add this to the Javadoc, either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
