xiedeyantu commented on code in PR #4761: URL: https://github.com/apache/calcite/pull/4761#discussion_r2806875552
########## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java: ########## @@ -60,7 +61,8 @@ public abstract class RelDataTypeImpl //~ Instance fields -------------------------------------------------------- protected final @Nullable List<RelDataTypeField> fieldList; - protected @Nullable String digest; + protected @Deprecated @Nullable String digest; Review Comment: Should we suggest using `RelDataTypeDigest.getDigest().getDigestString()` instead of `digest`? I also have a question: if a user extends and uses this field, will the current modification block the upgrade? Is this considered a blocking point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
