gnodet commented on PR #24856:
URL: https://github.com/apache/camel/pull/24856#issuecomment-5004382484
_Claude Code on behalf of gnodet_
@apupier Thanks for the detailed feedback! I've pushed a new commit
addressing all 6 review points:
1. **`SpringTokenXMLPairNamespaceSplitTest`**: Replaced `assertDoesNotThrow`
with `@Disabled("Not applicable for Spring XML variant")` — now clearly visible
in test reports as skipped
2. **`ErrorHandlerCamelContextRefNotFoundTest`**: Moved assertions from
`setUp()` into the test method `testErrorHandlerCamelContextRefNotFound()`,
renamed from `testDummy()`
3. **`ErrorHandlerRouteContextRefNotFoundTest`**: Same — moved assertions
into `testErrorHandlerRouteContextRefNotFound()`
4. **`OnExceptionNoExceptionConfiguredTest`**: Same — moved assertion into
`testOnExceptionNoExceptionConfigured()`
5. **`SpringRouteNoFromTest`**: Moved `assertThrows` from
`createApplicationContext()` into `testRouteNoFrom()`
6. **`SpringTraceTest`**: Replaced `assertDoesNotThrow` with real
`MockEndpoint` assertions — now verifies 2 messages are delivered to
`mock:result`
All 7 tests pass (6 run + 1 skipped via @Disabled).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
