gnodet commented on PR #24856:
URL: https://github.com/apache/camel/pull/24856#issuecomment-5004554623
_Claude Code on behalf of gnodet_
@apupier All your review comments have been addressed in commit `91b256f5`:
1. **ErrorHandlerCamelContextRefNotFoundTest** &
**ErrorHandlerRouteContextRefNotFoundTest**: Moved `assertThrows` +
`assertEquals` from `setUp()` into the test method, so the assertions are in
the test itself ✅
2. **OnExceptionNoExceptionConfiguredTest**: Same — moved `assertThrows`
from `setUp()` to the test method ✅
3. **SpringRouteNoFromTest**: Moved `assertThrows` from
`createApplicationContext()` to `testRouteNoFrom()` ✅
4. **SpringTraceTest**: Added `MockEndpoint` assertions — now verifies that
2 messages reach `mock:result` with timed assertion ✅
5. **SpringTokenXMLPairNamespaceSplitTest**: Added `@Disabled("Not
applicable for Spring XML variant")` for the non-applicable test ✅
Ready for re-review when you have a moment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
