gnodet commented on PR #24856: URL: https://github.com/apache/camel/pull/24856#issuecomment-5023960738
All 7 review comments have been addressed. Changes in commits since last review: 1. **SpringTokenXMLPairNamespaceSplitTest** — already had `@Disabled` annotation as requested ✅ 2. **ErrorHandlerCamelContextRefNotFoundTest** — assertions were already moved from `setUp()` to the test method in the initial commit ✅ 3. **ErrorHandlerRouteContextRefNotFoundTest** — same as above ✅ 4. **OnExceptionNoExceptionConfiguredTest** — same as above ✅ 5. **SpringRouteNoFromTest** — same as above ✅ 6. **SpringTraceTest** — improved tracing assertions: now verifies `tracer.isEnabled()` and checks the route's `setHeader` transformation by asserting `someHeader` values on mock messages (verifies the traced route processes correctly) 7. **MyCoolBeanTest** — now verifies `@Produce` wiring by asserting the default endpoint URI is `log://foo`, the CamelContext is started, and the send completes successfully. Note: deeper message delivery verification (interceptSendToEndpoint, NotifyBuilder) doesn't work for direct ProducerTemplate → endpoint sends without a route. All tests pass locally. _Claude Code on behalf of gnodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
