gnodet commented on PR #24856:
URL: https://github.com/apache/camel/pull/24856#issuecomment-5005100228
_Claude Code on behalf of gnodet_
@apupier Thank you for the feedback! All your comments have been addressed
in the latest commits:
1. **Assertions moved from `setUp()` to test methods** (commits
`91b256f5cb3c` and `c272430e67e8`):
- `ErrorHandlerCamelContextRefNotFoundTest` — assertions moved to
`testErrorHandlerCamelContextRefNotFound()`
- `ErrorHandlerRouteContextRefNotFoundTest` — assertions moved to
`testErrorHandlerRouteContextRefNotFound()`
- `OnExceptionNoExceptionConfiguredTest` — assertions moved to
`testOnExceptionNoExceptionConfigured()`
- `SpringRouteNoFromTest` — assertions moved to `testRouteNoFrom()`
2. **Test methods renamed** to clearly describe what is being tested (e.g.,
`testDummy()` → `testErrorHandlerCamelContextRefNotFound()`).
3. **`@Disabled` annotation added** to
`SpringTokenXMLPairNamespaceSplitTest.testTokenXMLPair2()` so reports clearly
show the test is skipped.
4. **`SpringTraceTest` now verifies tracing** — checks
`camelContext.isTracing()` returns `true` and `camelContext.getTracer()` is not
null, in addition to the mock endpoint assertion.
Could you please re-review when you get a chance? CI is currently running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
