gnodet commented on code in PR #26845:
URL: https://github.com/apache/camel/pull/26845#discussion_r4114672956
##########
components/camel-jdbc/src/main/java/org/apache/camel/component/jdbc/JdbcComponent.java:
##########
@@ -114,6 +116,13 @@ public void setConnectionStrategy(ConnectionStrategy
connectionStrategy) {
this.connectionStrategy = connectionStrategy;
}
+ @Override
+ public void onSecretRotation(Object source) throws Exception {
+ if (this.dataSource != null) {
Review Comment:
Fixed in cc0bb0fe070c. `onSecretRotation()` now delegates to
`DataSourceHelper.evictComponentDataSources()` which collects the component's
own `dataSource` plus the DataSources of all active endpoints belonging to this
component (filtered by `ep.getComponent() == this`), with identity-based
deduplication. This covers the `jdbc:myDs` case where
`JdbcComponent.dataSource` is null but the endpoint holds the resolved
DataSource.
##########
components/camel-sql/src/main/java/org/apache/camel/component/sql/SqlComponent.java:
##########
@@ -151,6 +153,13 @@ protected Endpoint createEndpoint(String uri, String
remaining, Map<String, Obje
return endpoint;
}
+ @Override
+ public void onSecretRotation(Object source) throws Exception {
+ if (this.dataSource != null) {
Review Comment:
Fixed in cc0bb0fe070c. Same approach as JdbcComponent — `onSecretRotation()`
now collects the component's own DataSource plus the DataSources from all
active `DefaultSqlEndpoint` instances belonging to this component, with
identity-based deduplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
